FrankYang0529 commented on code in PR #619:
URL: https://github.com/apache/yunikorn-k8shim/pull/619#discussion_r1237295347
##########
test/e2e/framework/helpers/yunikorn/wrappers.go:
##########
@@ -131,8 +131,7 @@ func RestoreConfigMapWrapper(oldConfigMap *v1.ConfigMap,
annotation string) {
var e, err3 = k.UpdateConfigMap(c,
configmanager.YuniKornTestConfig.YkNamespace)
Ω(err3).NotTo(HaveOccurred())
Ω(e).NotTo(BeNil())
- // Updating scheduler pod annotation to trigger force refresh of
configmaps
-
Ω(k.RemoveYunikornSchedulerPodAnnotation(annotation)).NotTo(HaveOccurred())
Review Comment:
It looks like `KubeCtl.RemoveYunikornSchedulerPodAnnotation` is only called
here. We can also remove it.
https://github.com/apache/yunikorn-k8shim/blob/292e26fd9d910be39bb98f3bc01b7445179dff9e/test/e2e/framework/helpers/k8s/k8s_utils.go#L945
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
