pbacsko commented on PR #622: URL: https://github.com/apache/yunikorn-k8shim/pull/622#issuecomment-1603194839
> Note: I updated some functions to return pointers in `pkg/common/si_helper.go`, because `go vet` return some errors like: > > ``` > pkg/common/si_helper.go:98:9: return copies lock value: github.com/apache/yunikorn-scheduler-interface/lib/go/si.AllocationRequest contains google.golang.org/protobuf/internal/impl.MessageState contains sync.Mutex > ``` That's good, mutexes are not supposed to be value-copied (just like atomic variables). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
