wilfred-s commented on code in PR #621:
URL: https://github.com/apache/yunikorn-k8shim/pull/621#discussion_r1239296487
##########
deployments/examples/authz/k8s-api-access/create-user.sh:
##########
@@ -16,15 +16,15 @@
# See the License for the specific language governing permissions and
# limitations under the License.
-USERS=("admin admin" "sue group-a" "bob group-a" "kim group-b" "yono group-b"
"anonymous anonymous")
+USERS=("admin" "sue" "bob" "kim" "yono" "anonymous")
+USERS_GROUP=("admin" "group-a" "group-a" "group-b" "group-b" "anonymous")
Review Comment:
Add a comment that the user and group should contain the same number of
elements.
If anyone wants no group or no user can we use an empty string, i.e. "" ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
