pbacsko commented on code in PR #573:
URL: https://github.com/apache/yunikorn-core/pull/573#discussion_r1239571433
##########
pkg/scheduler/partition_test.go:
##########
@@ -355,15 +355,15 @@ func TestRemoveNodeWithAllocations(t *testing.T) {
// wait for events to be processed
err = common.WaitFor(10*time.Millisecond, time.Second, func() bool {
fmt.Printf("checking event length: %d\n",
eventSystem.Store.CountStoredEvents())
- return eventSystem.Store.CountStoredEvents() == 1
+ return eventSystem.Store.CountStoredEvents() == 4 // 3 node
alloc + 1 app event
Review Comment:
Created a follow-up to address this:
https://issues.apache.org/jira/browse/YUNIKORN-1833.
The tests are becoming unmaintainable, this cannot be verified here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
