craigcondit commented on code in PR #321:
URL: https://github.com/apache/yunikorn-site/pull/321#discussion_r1248042036
##########
docs/user_guide/usergroup_resolution.md:
##########
@@ -86,14 +86,16 @@ metadata:
annotations:
yunikorn.apache.org/user.info: "
{
- username: \"yunikorn\",
- groups: [
+ \"user\": \"yunikorn\",
+ \"groups\": [
\"developers\",
\"devops\"
]
}"
```
+(NOTE: for historical reason, "username" is used in label
"yunikorn.apache.org/username", whereas, "user" is used in the annotation here)
Review Comment:
I think we should leave the note out as it's completely obsolete. It's
likely to cause more confusion than not. The old label still exists but has
completely different meaning and semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
