wilfred-s commented on code in PR #632:
URL: https://github.com/apache/yunikorn-k8shim/pull/632#discussion_r1255327531
##########
pkg/admission/util_test.go:
##########
@@ -263,18 +263,16 @@ func TestGenerateAppID(t *testing.T) {
conf.AMFilteringGenerateUniqueAppIds: fmt.Sprintf("%t", true),
})
- podUid := "abcd1234-5678-efgh-90ij-klmnopqrstuv"
-
// short namespace name
ns := "short"
- appID = generateAppID(ns, createTestingPodWithCustomFields(ns),
uniqueEnabled.GetGenerateUniqueAppIds())
Review Comment:
This leaves the function `createTestingPodWithCustomFields()` unused and we
should remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
