pbacsko commented on code in PR #581:
URL: https://github.com/apache/yunikorn-core/pull/581#discussion_r1256145486
##########
pkg/scheduler/objects/application_state_test.go:
##########
@@ -19,15 +19,22 @@
package objects
import (
+ "fmt"
"testing"
"time"
"gotest.tools/v3/assert"
"github.com/apache/yunikorn-core/pkg/common"
+ "github.com/apache/yunikorn-core/pkg/events"
+ "github.com/apache/yunikorn-scheduler-interface/lib/go/si"
)
func TestAcceptStateTransition(t *testing.T) {
+ events.CreateAndSetEventSystem()
Review Comment:
It's too much change of the existing tests.
I suggest that you create a new test case which triggers all state
transitions then you verify the events. That results in a more compact and
likely smaller change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
