zhuqi-lucas commented on code in PR #569:
URL: https://github.com/apache/yunikorn-core/pull/569#discussion_r1258239614


##########
pkg/scheduler/objects/queue.go:
##########
@@ -663,29 +663,61 @@ func (sq *Queue) AddApplication(app *Application) {
        // YUNIKORN-199: update the quota from the namespace
        // get the tag with the quota
        quota := app.GetTag(common.AppTagNamespaceResourceQuota)
-       if quota == "" {
+       // get the tag with the guaranteed resource
+       guaranteed := app.GetTag(common.AppTagNamespaceResourceGuaranteed)
+       if quota == "" && guaranteed == "" {

Review Comment:
   No @manirajv06 , it only uses when user annotation it just like quota, every 
annotation can be used independently.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to