pbacsko commented on code in PR #574:
URL: https://github.com/apache/yunikorn-core/pull/574#discussion_r1259416256
##########
pkg/scheduler/objects/queue.go:
##########
@@ -296,12 +302,18 @@ func (sq *Queue) applyConf(conf configs.QueueConfig)
error {
sq.isManaged = true
}
+ prevLeaf := sq.isLeaf
sq.isLeaf = !conf.Parent
// Make sure the parent flag is set correctly: config might expect auto
parent type creation
if len(conf.Queues) > 0 {
sq.isLeaf = false
}
+ if prevLeaf != sq.isLeaf && sq.initialized {
Review Comment:
Let me check, it looks reasonable...
##########
pkg/scheduler/objects/queue.go:
##########
@@ -296,12 +302,18 @@ func (sq *Queue) applyConf(conf configs.QueueConfig)
error {
sq.isManaged = true
}
+ prevLeaf := sq.isLeaf
sq.isLeaf = !conf.Parent
// Make sure the parent flag is set correctly: config might expect auto
parent type creation
if len(conf.Queues) > 0 {
sq.isLeaf = false
}
+ if prevLeaf != sq.isLeaf && sq.initialized {
Review Comment:
Let me check, it looks reasonable to change this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
