craigcondit commented on code in PR #629:
URL: https://github.com/apache/yunikorn-k8shim/pull/629#discussion_r1260442400
##########
pkg/cache/external/scheduler_cache.go:
##########
@@ -603,46 +603,24 @@ func (cache *SchedulerCache) IsPVCUsedByPods(key string)
bool {
return ok
}
-func (cache *SchedulerCache) maxNodeGeneration() int64 {
- var maxGeneration int64
- for _, node := range cache.nodesMap {
- if maxGeneration < node.Generation {
- maxGeneration = node.Generation
+func (cache *SchedulerCache) updatePVCRefCounts(node *framework.NodeInfo,
removeNode bool) {
+ for k, v := range cache.pvcRefCounts {
+ delete(v, node.Node().Name)
Review Comment:
Save node.Node().Name to a variable at the top of the function so it can be
re-used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
