craigcondit commented on code in PR #589:
URL: https://github.com/apache/yunikorn-core/pull/589#discussion_r1263601818
##########
pkg/webservice/handlers.go:
##########
@@ -869,3 +891,90 @@ func getGroupResourceUsage(w http.ResponseWriter, r
*http.Request) {
buildJSONErrorResponse(w, err.Error(),
http.StatusInternalServerError)
}
}
+
+func getEventsByType(w http.ResponseWriter, r *http.Request) {
Review Comment:
That's better than nothing but doesn't give any ability to correlate
messages with the ID they were generated with. Also, if a client is interested
in more than one filtered data stream, they now need to query for all of them
individually resulting in more work server-side. Why not just filter on the
client? Data transfer is cheaper than CPU time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
