wilfred-s commented on code in PR #597:
URL: https://github.com/apache/yunikorn-core/pull/597#discussion_r1275679955
##########
pkg/scheduler/objects/application.go:
##########
@@ -1638,6 +1640,7 @@ func (sa *Application) addAllocationInternal(info
*Allocation) {
zap.Error(err))
}
}
+ sa.hasPlaceholderAlloc.Store(true)
Review Comment:
-1 that cannot work.
Applications at the partition level are a map of all applications in the
partition. The queue that we are checking needs to make the decision. At the
partition level we do not know if the specific queue the app is running in has
pending requests. We also do not want to walk over all applications at the
partition level as that would not take into account any queue details.
Filtering out that early does not work.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
