manirajv06 commented on code in PR #597:
URL: https://github.com/apache/yunikorn-core/pull/597#discussion_r1275824307
##########
pkg/scheduler/objects/application.go:
##########
@@ -1712,6 +1715,17 @@ func (sa *Application) ReplaceAllocation(uuid string)
*Allocation {
if sa.placeholderData != nil {
sa.placeholderData[ph.GetTaskGroup()].Replaced++
}
+
+ // check if we have active placeholder allocation left
+ hasReplaceablePlaceholder := false
+ for _, phData := range sa.placeholderData {
Review Comment:
Yes, it is good to set/unset in existing places (appropriate as described).
do we need to unset even when app transition to work as non-gang because of
"soft" style"?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
