wilfred-s commented on code in PR #127:
URL: https://github.com/apache/yunikorn-web/pull/127#discussion_r1289636298
##########
src/app/utils/common.util.ts:
##########
@@ -30,7 +30,7 @@ export class CommonUtil {
return uniqid;
}
- static formatMemory(value: number | string): string {
+ static formatBytes(value: number | string): string {
Review Comment:
I only just noticed: we do not comply with the prefix definitions here:
[](https://physics.nist.gov/cuu/Units/prefixes.html)
We use SI units but use a capital K. Filed a follow up jira to fix that
throughout the web code
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
