wilfred-s commented on code in PR #628:
URL: https://github.com/apache/yunikorn-k8shim/pull/628#discussion_r1289668147
##########
pkg/appmgmt/general/podevent_handler.go:
##########
@@ -127,6 +130,15 @@ func (p *PodEventHandler) addPod(pod *v1.Pod, eventSource
EventSource) interface
Metadata: appMeta,
})
} else {
+ if
conf.GetSchedulerConf().GetSingleUserPerApplication() && app.GetUser() !=
appMeta.User {
Review Comment:
This is not good enough as it will break the autogen IDs. If we generate one
ID per namespace the system comes to a grinding halt. That behaviour is managed
by the setting in `admissionController.filtering.generateUniqueAppId` if that
is false (default) all pods that miss an app ID will have it set to:
`yunikorn-NAMESPACE-autogen` that could be for multiple users.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
