lixmgl opened a new pull request, #660:
URL: https://github.com/apache/yunikorn-core/pull/660

   …n of guaranteed resource at a parent queue level
   
   ### What is this PR for?
   We noticed Preemption happened when a queue lower than its guaranteed 
capacity, caused issue in production.
   This pr including changes:
   
   1. The calculation for extraVictims and appending it to victims is now 
within a condition that checks if needsAdditionalVictims is true. extraVictims 
are only calculated and appended when there's a need for additional victims 
based on the tryNodes function result.
   2. p.calculateAdditionalVictims(victims, nodeID) now takes in nodeID as a 
parameter, showing that this function may now consider the nodeID in its 
calculation for extra victims.
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-1988
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to