wilfred-s commented on code in PR #688:
URL: https://github.com/apache/yunikorn-k8shim/pull/688#discussion_r1361527840


##########
test/e2e/framework/helpers/common/utils.go:
##########
@@ -116,7 +114,6 @@ func GetUUID() string {
 
 func RandSeq(n int) string {
        var letters = []rune("abcdefghijklmnopqrstuvwxyz0123456789")
-       rand.Seed(time.Now().UnixNano())

Review Comment:
   This is no longer needed in Go 1.20, same discussion I had with Craig on the 
placeholder name generation. Yes we can remove the Seed() call.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to