brandboat opened a new pull request, #691:
URL: https://github.com/apache/yunikorn-k8shim/pull/691

   ### What is this PR for?
   There are some useful placement rule examples under 
https://github.com/apache/yunikorn-k8shim/tree/master/deployments/examples/placements
   
   while there are some incorrect settings in them:
   - `queue.yaml` should be `queues.yaml`
   - label `yunikorn.apache.org/username` is legacy and should be switched to 
annotation `yunikorn.apache.org/user.info`
   
   Correct me if I'm wrong, the backward compatibility for the label 
`yunikorn.apache.org/username` seems broken. The placement rules examples in 
the link mentioned will not work with the label, but will only be effective 
with the annotation (i.e., `yunikorn.apache.org/user.info`).
   
   ### What type of PR is it?
   * [x] - Documentation
   
   ### Todos
   N/A
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-2049
   
   ### How should this be tested?
   N/A
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   N/A
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to