wilfred-s commented on code in PR #678:
URL: https://github.com/apache/yunikorn-core/pull/678#discussion_r1366488803
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -548,14 +548,18 @@ func (p *Preemptor) TryPreemption() (*Allocation, bool) {
victimQueue.IncPreemptingResource(victim.GetAllocatedResource())
victim.MarkPreempted()
log.Log(log.SchedPreemption).Info("Preempting task",
- zap.String("applicationID",
victim.GetApplicationID()),
- zap.String("allocationKey",
victim.GetAllocationKey()),
+ zap.String("victimApplicationID",
victim.GetApplicationID()),
+ zap.String("victimAllocationKey",
victim.GetAllocationKey()),
zap.String("nodeID", victim.GetNodeID()),
- zap.Stringer("resources",
victim.GetAllocatedResource()))
+ zap.Stringer("resources",
victim.GetAllocatedResource()),
+ zap.String("askApplicationID",
p.ask.applicationID),
+ zap.String("askAllocationKey",
p.ask.allocationKey),
+ zap.String("askQueue", p.ask.String()),
+ zap.String("victimQueue", victimQueue.Name))
} else {
log.Log(log.SchedPreemption).Warn("BUG: Queue not found
for preemption victim",
- zap.String("applicationID",
victim.GetApplicationID()),
- zap.String("allocationKey",
victim.GetAllocationKey()))
+ zap.String("victimApplicationID",
victim.GetApplicationID()),
+ zap.String("victimAllocationKey",
victim.GetAllocationKey()))
Review Comment:
Which queue was not found?
##########
pkg/scheduler/objects/preemption.go:
##########
@@ -548,14 +548,18 @@ func (p *Preemptor) TryPreemption() (*Allocation, bool) {
victimQueue.IncPreemptingResource(victim.GetAllocatedResource())
victim.MarkPreempted()
log.Log(log.SchedPreemption).Info("Preempting task",
- zap.String("applicationID",
victim.GetApplicationID()),
- zap.String("allocationKey",
victim.GetAllocationKey()),
+ zap.String("victimApplicationID",
victim.GetApplicationID()),
+ zap.String("victimAllocationKey",
victim.GetAllocationKey()),
zap.String("nodeID", victim.GetNodeID()),
- zap.Stringer("resources",
victim.GetAllocatedResource()))
+ zap.Stringer("resources",
victim.GetAllocatedResource()),
+ zap.String("askApplicationID",
p.ask.applicationID),
+ zap.String("askAllocationKey",
p.ask.allocationKey),
+ zap.String("askQueue", p.ask.String()),
+ zap.String("victimQueue", victimQueue.Name))
Review Comment:
Main comment: sort the info you log.
* start with requesting details: ask
* add requesting resource details
* keep all victim info and requesting info grouped together
* use same order in victim and requesting detail: app, key, queue, resource
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
