pbacsko commented on code in PR #680:
URL: https://github.com/apache/yunikorn-core/pull/680#discussion_r1367822019
##########
pkg/scheduler/tests/operation_test.go:
##########
@@ -196,7 +196,7 @@ partitions:
// Check scheduling queue a
queueA := part.GetQueue("root.a")
- assert.Assert(t, 150000000 ==
queueA.GetMaxResource().Resources[common.Memory])
+ assert.Assert(t, queueA.GetMaxResource().Resources[common.Memory] ==
150000000)
Review Comment:
Could you change this to assert.Equal() ?
##########
pkg/scheduler/tests/operation_test.go:
##########
@@ -68,7 +68,7 @@ partitions:
// Check scheduling queue a
queueA := part.GetQueue("root.a")
- assert.Assert(t, 150000000 ==
queueA.GetMaxResource().Resources[common.Memory])
+ assert.Assert(t, queueA.GetMaxResource().Resources[common.Memory] ==
150000000)
Review Comment:
Could you change this to assert.Equal() ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
