doupache commented on PR #669: URL: https://github.com/apache/yunikorn-core/pull/669#issuecomment-1778723891
CI Pass on my fork https://github.com/doupache/yunikorn-core/actions/runs/6637146374 So I think is ready for review! the git diff may look a little bit confused. I basically just 1. move ``` userLimits := make(map[string]bool) groupLimits := make(map[string]bool) ``` those initialization from `internalProcessConfig` to `UpdateConfig` because we need to keep userLimits and groupLimits in the whole queue traversing . And pass them to `internalProcessConfig`. 2. preorder to postorder. 3. add test from https://github.com/apache/yunikorn-core/pull/600#discussion_r1286898707 @FrankYang0529 @manirajv06 please take a look. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
