brandboat commented on code in PR #663:
URL: https://github.com/apache/yunikorn-core/pull/663#discussion_r1371545533


##########
pkg/scheduler/objects/application.go:
##########
@@ -990,7 +990,7 @@ func (sa *Application) tryAllocate(headRoom 
*resources.Resource, preemptionDelay
                        // the iterator might not have the node we need as it 
could be reserved, or we have not added it yet
                        node := getNodeFn(requiredNode)
                        if node == nil {
-                               log.Log(log.SchedApplication).Warn("required 
node is not found (could be transient)",
+                               log.Log(log.SchedApplication).Debug("required 
node is not found (could be transient)",

Review Comment:
   > Could you use a rate-limit approach? It's still an issue if someone 
decides to use Debug level.
   > 
   > I propose a natural single msg/second limit.
   
   I've added a RateLimitedLogger in the latest commit, appreciated for the 
comment.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to