craigcondit commented on PR #690: URL: https://github.com/apache/yunikorn-core/pull/690#issuecomment-1792858843
> > Why not use the existing parameter in the partition config for this? (See jira for details also) > > Because then we end up with opt-in preemption rather than opt out as there's no distinction in the existing configuration between Enabled: false and not specified. That's backwards-incompatible. Managed to get this working by changing the type of the Enabled field in the config to *bool, so we can detect unset values and default to true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org