brandboat opened a new pull request, #696:
URL: https://github.com/apache/yunikorn-core/pull/696

   ### What is this PR for?
   in unit test queue_test.go#TestNewConfiguredQueue
   
   `// case 0: leaf can use template`
   
https://github.com/apache/yunikorn-core/blob/284cc92974a7330c95ad3c6ecdf05ea68b9eee9d/pkg/scheduler/objects/queue_test.go#L2225-L2226
   
   This test is flawed as it erroneously allows managed leaf queues to utilize 
child template and it consistently passes because the `getResourceConf` and 
`getProperties` lack the required randomness.
   
   ### What type of PR is it?
   * [x] - Bug Fix
   
   ### Todos
   N/A
   
   ### What is the Jira issue?
   https://issues.apache.org/jira/browse/YUNIKORN-2124
   
   ### How should this be tested?
   covered by unit test
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to