zhuqi-lucas opened a new pull request, #710:
URL: https://github.com/apache/yunikorn-core/pull/710
### What is this PR for?
We should not preempt placeholders which has been released, it will cause
the real pod pending due to not get the response:
```
The real pod will always pending, because the core side doesn't receive the
release response for PLACEHOLDER_REPLACED
// if we have an uuid the termination type is important
if release.TerminationType == si.TerminationType_PLACEHOLDER_REPLACED {
log.Logger().Info("replacing placeholder allocation",
zap.String("appID", appID),
zap.String("allocationId", uuid))
if alloc := app.ReplaceAllocation(uuid); alloc != nil {
released = append(released, alloc)
}
} else {
log.Logger().Info("removing allocation from application",
zap.String("appID", appID),
zap.String("allocationId", uuid),
zap.String("terminationType", release.TerminationType.String()))
if alloc := app.RemoveAllocation(uuid); alloc != nil {
released = append(released, alloc)
}
}
```
### What type of PR is it?
* [ ] - Bug Fix
* [ ] - Improvement
* [ ] - Feature
* [ ] - Documentation
* [ ] - Hot Fix
* [ ] - Refactoring
### Todos
* [ ] - Task
### What is the Jira issue?
* Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN-2141
* Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg.
`[YUNIKORN-2] Gang scheduling interface parameters`
### How should this be tested?
### Screenshots (if appropriate)
### Questions:
* [ ] - The licenses files need update.
* [ ] - There is breaking changes for older versions.
* [ ] - It needs documentation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
