manirajv06 commented on code in PR #712:
URL: https://github.com/apache/yunikorn-core/pull/712#discussion_r1393746422
##########
pkg/common/configs/configvalidator.go:
##########
@@ -539,8 +539,8 @@ func checkLimit(limit Limit, existedUserName
map[string]bool, existedGroupName m
zap.Error(err))
return err
}
- if resources.IsZero(limitResource) {
- return fmt.Errorf("MaxResources is zero in '%s' limit,
all resource types are zero", limit.Limit)
+ if !resources.StrictlyGreaterThanZero(limitResource) {
+ return fmt.Errorf("MaxResources is not greater than
zero in '%s' limit", limit.Limit)
Review Comment:
MaxResources is not greater than zero in '%s' limit -> MaxResources should
be greater than zero in '%s' limit ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
