brandboat commented on code in PR #697:
URL: https://github.com/apache/yunikorn-core/pull/697#discussion_r1395543721
##########
pkg/scheduler/objects/template/template.go:
##########
@@ -44,7 +45,7 @@ func FromConf(template *configs.ChildTemplate) (*Template,
error) {
return true
}
- if template == nil || (isMapEmpty(template.Properties) &&
isMapEmpty(template.Resources.Guaranteed) &&
isMapEmpty(template.Resources.Max)) {
+ if template == nil || (template.MaxApplications == 0 &&
isMapEmpty(template.Properties) && isMapEmpty(template.Resources.Guaranteed) &&
isMapEmpty(template.Resources.Max)) {
Review Comment:
Already address comments in the latest comment, many thanks !
##########
pkg/scheduler/objects/template/template.go:
##########
@@ -44,7 +45,7 @@ func FromConf(template *configs.ChildTemplate) (*Template,
error) {
return true
}
- if template == nil || (isMapEmpty(template.Properties) &&
isMapEmpty(template.Resources.Guaranteed) &&
isMapEmpty(template.Resources.Max)) {
+ if template == nil || (template.MaxApplications == 0 &&
isMapEmpty(template.Properties) && isMapEmpty(template.Resources.Guaranteed) &&
isMapEmpty(template.Resources.Max)) {
Review Comment:
Already addressed the comment in the latest commit, many thanks !
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
