craigcondit opened a new pull request, #728: URL: https://github.com/apache/yunikorn-k8shim/pull/728
Refactoring of AppManager implementations to consolidate into AppManagementService. - Merged general app manager into AppManagementService - Migrated pkg/appmgmt/* -> pkg/cache/* - Migrated pkg/callback/* -> pkg/cache/* - Migrated various utils -> pkg/cache/ to avoid circular dependencies - Removed Recoverable interface (functionality merged into AppManagementService) - Removed AppManager interface (functionality merged into AppManagementService) - Removed ManagedApp and ManagedTask interfaces - Skipped (currently) broken recovery tests due to interfaces not being usable. These tests will be rewritten in a future PR once the recovery code is integrated into the context. ### What type of PR is it? * [ ] - Bug Fix * [ ] - Improvement * [ ] - Feature * [ ] - Documentation * [ ] - Hot Fix * [x] - Refactoring ### Todos * [ ] - Task ### What is the Jira issue? https://issues.apache.org/jira/browse/YUNIKORN-2159 ### How should this be tested? ### Screenshots (if appropriate) ### Questions: * [ ] - The licenses files need update. * [ ] - There is breaking changes for older versions. * [ ] - It needs documentation. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
