yzhangal commented on code in PR #641:
URL: https://github.com/apache/yunikorn-core/pull/641#discussion_r1398000272
##########
pkg/metrics/queue.go:
##########
@@ -105,80 +107,83 @@ func InitQueueMetrics(name string) CoreQueueMetrics {
func (m *QueueMetrics) Reset() {
m.appMetricsLabel.Reset()
m.appMetricsSubsystem.Reset()
- m.ResourceMetricsLabel.Reset()
- m.ResourceMetricsSubsystem.Reset()
+ m.resourceMetricsLabel.Reset()
+ m.resourceMetricsSubsystem.Reset()
+}
+
+func (m *QueueMetrics) IncQueueApplications(state string) {
Review Comment:
Thanks for the new rev @WilliamTom
It LGTM except for one very nit: util method (this and other similar ones)
that’s only used within the class is private method, use lower case for the
first letter of the method name. Can wait for other comments if there are any.
Thanks.
##########
pkg/metrics/queue.go:
##########
@@ -105,80 +107,83 @@ func InitQueueMetrics(name string) CoreQueueMetrics {
func (m *QueueMetrics) Reset() {
m.appMetricsLabel.Reset()
m.appMetricsSubsystem.Reset()
- m.ResourceMetricsLabel.Reset()
- m.ResourceMetricsSubsystem.Reset()
+ m.resourceMetricsLabel.Reset()
+ m.resourceMetricsSubsystem.Reset()
+}
+
+func (m *QueueMetrics) IncQueueApplications(state string) {
Review Comment:
Thanks for the new rev @WilliamTom
It LGTM except for one very nit: util method (this and other similar ones)
that’s only used within the class is private method, use lower case for the
first letter of the method name. Can wait for other comments if there are any.
Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
