zhuqi-lucas opened a new pull request, #730:
URL: https://github.com/apache/yunikorn-k8shim/pull/730

   ### What is this PR for?
   We should clean up app terminal status for shim side:
   
   Clean up terminal failed apps for shim side
                1. When we reject an app, we set the app state to Rejected, and 
immediately set it to Failed, but we don't clean up the app.
                2. When we failed an app, we set the app state to Failed, but 
we don't clean up the app.
                3. The completed app already handled by  UpdateApplication 
function.
                   case cache.ApplicationStates().Completed:
                                
callback.context.RemoveApplicationInternal(updated.ApplicationID)
                4. The killed status is not used until now, so we don't need to 
handle it.
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [ ] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   * [ ] - Task
   
   ### What is the Jira issue?
   * Open an issue on Jira https://issues.apache.org/jira/browse/YUNIKORN/
   * Put link here, and add [YUNIKORN-*Jira number*] in PR title, eg. 
`[YUNIKORN-2] Gang scheduling interface parameters`
   
   ### How should this be tested?
   
   ### Screenshots (if appropriate)
   
   ### Questions:
   * [ ] - The licenses files need update.
   * [ ] - There is breaking changes for older versions.
   * [ ] - It needs documentation.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to