pbacsko commented on code in PR #727:
URL: https://github.com/apache/yunikorn-core/pull/727#discussion_r1401944785
##########
pkg/webservice/dao/queue_info.go:
##########
@@ -33,6 +33,7 @@ type PartitionQueueDAOInfo struct {
GuaranteedResource map[string]int64
`json:"guaranteedResource,omitempty"`
AllocatedResource map[string]int64
`json:"allocatedResource,omitempty"`
PreemptingResource map[string]int64
`json:"preemptingResource,omitempty"`
+ HeadRoom map[string]int64
`json:"headroom,omitempty"`
Review Comment:
It's not tested whether this value appears properly after a web service
call. It's not just this field, but quite a few inside `PartitionQueueDAOInfo`.
There's a test case `TestGetPartitionQueuesHandler` which should be improved to
see if values from the schedulerContext are mapped back properly. This can be
done in a follow-up JIRA.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
