doupache commented on PR #735: URL: https://github.com/apache/yunikorn-k8shim/pull/735#issuecomment-1825353777
Hi @pegasas, thanks for the effort! I am working on https://issues.apache.org/jira/browse/YUNIKORN-1950 But i found a bug and try to fix it. add to following test to the end TestUserGroupLimitChange test. ```go //remove Limits , so we can run TestApp2 again conf.Queues[0].Queues[0].Limits = nil assert.NilError(t, manager.UpdateConfig(conf.Queues[0], "root")) increased = manager.IncreaseTrackedResource(queuePathParent, TestApp2, usage, tc.user) assert.Equal(t, increased, true, "unable to increase tracked resource: queuepath "+queuePathParent+", app "+TestApp2+", res "+usage.String()) decreased = manager.DecreaseTrackedResource(queuePathParent, TestApp2, usage, tc.user, true) assert.Equal(t, decreased, true, "unable to decreased tracked resource: queuepath "+queuePathParent+", app "+TestApp2+", res "+usage.String()) //set newLimits again, we should not run TestApp2 now conf.Queues[0].Queues[0].Limits = tc.newLimits assert.NilError(t, manager.UpdateConfig(conf.Queues[0], "root")) increased = manager.IncreaseTrackedResource(queuePathParent, TestApp2, usage, tc.user) assert.Equal(t, increased, false, "should not increase tracked resource: queuepath "+queuePathParent+", app "+TestApp2+", res "+usage.String()) ``` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
