targetoee opened a new pull request, #736:
URL: https://github.com/apache/yunikorn-k8shim/pull/736

   ### What is this PR for?
   This PR focus on fix linter issues about `goconst` warning. Some const are 
set for better reuse.
   
   ### What type of PR is it?
   * [ ] - Bug Fix
   * [x] - Improvement
   * [ ] - Feature
   * [ ] - Documentation
   * [ ] - Hot Fix
   * [ ] - Refactoring
   
   ### Todos
   This PR only fixes the parts which are pointed out by the linter. 
   While in `application_test.go`, the naming of variable names doesn't have a 
unified format. 
   It would be better to reformat that, and one way to achieve this is by 
setting common variables in `util_test.go` and reuse them.
   
   ### What is the Jira issue?
   
[YUNIKORN-2184](https://issues.apache.org/jira/projects/YUNIKORN/issues/YUNIKORN-2184)
   
   ### How should this be tested?
   It's been test using `./tools/golanci-lint run ./... | grep goconst` to 
checkout all the goconst waring are fixed.
   
   ### Screenshots (if appropriate)
   N/A
   
   ### Questions:
   N/A


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to