pbacsko commented on code in PR #533:
URL: https://github.com/apache/yunikorn-core/pull/533#discussion_r1407391656
##########
pkg/webservice/webservice.go:
##########
@@ -63,12 +64,13 @@ func loggingHandler(inner http.Handler, name string)
http.HandlerFunc {
// TODO we need the port to be configurable
func (m *WebService) StartWebApp() {
router := newRouter()
+ // Important: do not use ReadTimeout, WriteTimeout or IdleTimeout
because those can break the event streaming
Review Comment:
`ReadHeaderTimeout` is fine, it's the rest what can cause issues. Will check
out ResponseController, looks like it's relevant to us.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
