wusamzong commented on code in PR #148:
URL: https://github.com/apache/yunikorn-web/pull/148#discussion_r1408135366
##########
src/app/components/nodes-view/nodes-view.component.ts:
##########
@@ -188,6 +188,20 @@ export class NodesViewComponent implements OnInit {
return this.allocDataSource.data && this.allocDataSource.data.length === 0;
}
+ formatColumn(){
+ if(this.nodeDataSource.data.length==0){
+ return
+ }
+ this.nodeColumnIds.forEach((colId)=>{
+ let emptyCell=this.nodeDataSource.data.filter((node)=>{
+ return (node as any)[colId]=="" || (node as any)[colId]=="n/a"
+ })
+ if (emptyCell.length==this.nodeDataSource.data.length){
+ this.nodeColumnIds = this.nodeColumnIds.filter(el => el!==colId)
+ }
+ })
Review Comment:
Thanks for your suggestion.
However, I believe there is a bug in the original code that prevents
checking if all cells in the column are empty.
Consequently, I have refactored the implementation and utilized a foreach
loop to address the safety concerns you raised.
The changes have been updated in a new commit.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
