stu01509 commented on code in PR #739:
URL: https://github.com/apache/yunikorn-k8shim/pull/739#discussion_r1410821025
##########
pkg/cache/placeholder_test.go:
##########
@@ -140,10 +140,16 @@ func TestNewPlaceholderWithLabelsAndAnnotations(t
*testing.T) {
app.setTaskGroupsDefinition(string(marshalledTaskGroups))
holder := newPlaceholder("ph-name", app, app.taskGroups[0])
- assert.Equal(t, len(holder.pod.Labels), 5)
+
+ assert.DeepEqual(t, holder.pod.Labels, map[string]string{
+ "applicationId": "app01",
+ "labelKey0": "labelKeyValue0",
+ "labelKey1": "labelKeyValue1",
+ "placeholder": "true",
+ "queue": "root.default",
+ })
Review Comment:
https://github.com/apache/yunikorn-k8shim/pull/239/files#r592236442
I didn't refactor the `holder.pod.Annotations`, because it contains
`yunikorn.apache.org/task-groups` has a long value.
<img width="1539" alt="Screenshot 2023-11-30 at 10 48 39 PM"
src="https://github.com/apache/yunikorn-k8shim/assets/22230889/b8ad1f67-8620-48a2-bfb2-3c8a1dd6f3f0";>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
