targetoee commented on code in PR #374: URL: https://github.com/apache/yunikorn-site/pull/374#discussion_r1417459581
########## docs/developer_guide/deployment.md: ########## @@ -60,13 +60,13 @@ This kubernetes environment can be either local or remote. ``` curl -o yunikorn-configs.yaml https://raw.githubusercontent.com/apache/yunikorn-k8shim/master/deployments/scheduler/yunikorn-configs.yaml ``` -- modify the content of yunikorn-configs.yaml file as needed, and create ConfigMap in kubernetes: +- modify the content of yunikorn-configs.yaml file as needed, and apply yunikorn-configs.yaml file in kubernetes: ``` -kubectl create configmap yunikorn-configs --from-file=yunikorn-configs.yaml +kubectl apply -f yunikorn-configs.yaml ``` -- Or update ConfigMap in kubernetes: +- if configuration changes are needed, update the yunikorn-configs.yaml file and apply it again: Review Comment: I agree with @chia7712 that this part is redundant. The instruction already cover both creating and updating. Also the opinion of @craigcondit is reasonable. I add a reference link to it. Thanks for the advice. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
