wilfred-s commented on code in PR #146:
URL: https://github.com/apache/yunikorn-web/pull/146#discussion_r1419887420
##########
src/app/services/scheduler/scheduler.service.ts:
##########
@@ -350,7 +350,7 @@ export class SchedulerService {
if (resource[`ephemeral-storage`] == 0) {
formatted.push(`ephemeral-storage: ${NOT_AVAILABLE}`);
}else{
- formatted.push(`ephemeral-storage:
${CommonUtil.formatBytes(resource[key])}`);
+ formatted.push(`ephemeral-storage:
${CommonUtil.formatEphemeralStorageBytes(resource[key])}`);
Review Comment:
All `hugepages-*` resources fall into a special category also. They are
memory sizes and should be displayed as such.
Can use the multiple case value support javascript has here if we use
``formatted.push(`${key}: ...``
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
