zhuqi-lucas commented on code in PR #747:
URL: https://github.com/apache/yunikorn-core/pull/747#discussion_r1421336650
##########
pkg/scheduler/ugm/manager_test.go:
##########
@@ -1133,6 +1158,151 @@ func TestUserGroupLimitChange(t *testing.T) {
//nolint:funlen
createLimit(nil, []string{"group1"},
mediumResource, 2),
},
},
+ {
+ name: "maxapplications with an updated specific group
limit",
+ user: security.UserGroup{User: "user1", Groups:
[]string{"group1"}},
+ limits: []configs.Limit{
+ createLimit(nil, []string{"group1"},
largeResource, 2),
+ },
+ newLimits: []configs.Limit{
+ createLimit(nil, []string{"group1"},
largeResource, 1),
+ },
+ },
+
+ // user wilcard limit
+ {
+ name: "maxresources with an updated wildcard user
limit",
+ user: security.UserGroup{User: "user2", Groups:
[]string{"group2"}},
+ limits: []configs.Limit{
+ createLimit([]string{"user1"}, nil,
tinyResource, 2),
+ createLimit([]string{"*"}, nil, largeResource,
2),
+ },
+ newLimits: []configs.Limit{
+ createLimit([]string{"user1"}, nil,
largeResource, 2),
+ createLimit([]string{"*"}, nil, mediumResource,
2),
+ },
+ },
+ {
+ name: "maxapplications with an updated wildcard user
limit",
+ user: security.UserGroup{User: "user2", Groups:
[]string{"group2"}},
+ limits: []configs.Limit{
+ createLimit([]string{"user1"}, nil,
tinyResource, 1),
+ createLimit([]string{"*"}, nil, largeResource,
2),
+ },
+ newLimits: []configs.Limit{
+ createLimit([]string{"user1"}, nil,
largeResource, 2),
+ createLimit([]string{"*"}, nil, largeResource,
1),
+ },
+ },
+
+ // group wilcard limit
+ {
+
+ name: "maxresources with an updated wildcard group
limit",
+ user: security.UserGroup{User: "user2", Groups:
[]string{"group2"}},
+ limits: []configs.Limit{
+ createLimit(nil, []string{"group1"},
tinyResource, 2),
+ createLimit(nil, []string{"*"}, largeResource,
2),
+ },
+ newLimits: []configs.Limit{
+ createLimit(nil, []string{"group1"},
largeResource, 2),
+ createLimit(nil, []string{"*"}, mediumResource,
2),
+ },
+ },
+ {
+ name: "maxapplications with an updated wildcard group
limit",
+ user: security.UserGroup{User: "user2", Groups:
[]string{"group2"}},
+ limits: []configs.Limit{
+ createLimit(nil, []string{"group1"},
tinyResource, 1),
+ createLimit(nil, []string{"*"}, largeResource,
2),
+ },
+ newLimits: []configs.Limit{
+ createLimit(nil, []string{"group1"},
largeResource, 2),
+ createLimit(nil, []string{"*"}, largeResource,
1),
+ },
+ },
+
+ // in a different limit
+ {
+ name: "maxresources with a new specific user limit",
Review Comment:
Sorry @manirajv06 didn't notice this comments, the PR was merged, any
improvement can be done a separate jira. @doupache
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
