chia7712 commented on code in PR #755:
URL: https://github.com/apache/yunikorn-core/pull/755#discussion_r1422808609
##########
pkg/webservice/handlers.go:
##########
@@ -859,7 +859,7 @@ func getGroupsResourceUsage(w http.ResponseWriter, r
*http.Request) {
writeHeaders(w)
userManager := ugm.GetUserManager()
groupsResources := userManager.GetGroupsResources()
- var result []*dao.GroupResourceUsageDAOInfo
+ result := []*dao.GroupResourceUsageDAOInfo{}
Review Comment:
ditto
##########
pkg/webservice/handlers.go:
##########
@@ -823,7 +823,7 @@ func getUsersResourceUsage(w http.ResponseWriter, _
*http.Request) {
writeHeaders(w)
userManager := ugm.GetUserManager()
usersResources := userManager.GetUsersResources()
- var result []*dao.UserResourceUsageDAOInfo
+ result := []*dao.UserResourceUsageDAOInfo{}
Review Comment:
how about using `make` with initial capacity?
```
result := make([]*dao.UserResourceUsageDAOInfo, len(usersResources))
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
