FrankYang0529 commented on code in PR #720:
URL: https://github.com/apache/yunikorn-core/pull/720#discussion_r1425434712
##########
pkg/common/configs/configvalidator.go:
##########
@@ -172,6 +172,11 @@ func checkLimitResource(cur QueueConfig, users
map[string]map[string]*resources.
}
// Override with min resource
users[curQueuePath][user] =
resources.ComponentWiseMinPermissive(limitMaxResources, userMaxResource)
+ } else if wildcardMaxResource, ok :=
users[queuePath][common.Wildcard]; user != common.Wildcard && ok {
+ if
!wildcardMaxResource.FitInMaxUndef(limitMaxResources) {
+ return fmt.Errorf("user %s max resource
%s of queue %s is greater than wildcard maximum resource %s of immediate or
ancestor parent queue", user, limitMaxResources.String(), cur.Name,
wildcardMaxResource.String())
+ }
+ users[curQueuePath][user] = limitMaxResources
Review Comment:
Hi @manirajv06, thanks for the review. My bad, I changed `hasError` check to
`errMsg` and forgot to remove the `hasError` attribute. That is why your test
case is failed. May you change `hasError: true` to `errMsg: "is greater than
wildcard maximum resource"`? I can pass with that. Thank you.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
