chenyulin0719 commented on PR #754: URL: https://github.com/apache/yunikorn-core/pull/754#issuecomment-1857377383
Hi @manirajv06, > Though this proposal looks good, I am not sure whether UI changes can be pushed through around same time. I'll push these changes together (Core/UI), this might require the assistance of someone from the committer group. (I should push it after slow down?) > To minimize the effort on UI side, it is better to keep the dominant resource check in the core for some more time and always keep the dominant resource as the fist item in the response array. Base on the Slack discussion, we'll need to calculate the weight of multiple resources in UI after YUNIKORN-2088. (ex: to show only top N resoruces) So the domain resource calculation in core is redundant, and the UI calculation is quite simple, which should not impact the UI performance. So I still prefer to remove dominant resource check in core. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
