craigcondit commented on code in PR #773:
URL: https://github.com/apache/yunikorn-core/pull/773#discussion_r1454168761


##########
pkg/scheduler/objects/application.go:
##########
@@ -973,7 +974,10 @@ func (sa *Application) tryAllocate(headRoom 
*resources.Resource, allowPreemption
                        // the iterator might not have the node we need as it 
could be reserved, or we have not added it yet
                        node := getNodeFn(requiredNode)
                        if node == nil {
-                               rateLimitedLog.Warn("required node is not found 
(could be transient)",
+                               if appLog == nil {

Review Comment:
   Yes, that's generally the preferred approach. Also, once the PR is ready for 
review, it's best not to force push - we squash all commits when merging 
anyway, and force-pushing makes incremental reviewing harder.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to