chenyulin0719 commented on PR #160: URL: https://github.com/apache/yunikorn-web/pull/160#issuecomment-1924283408
Hi @craigcondit , @chia7712 , Just update a newer version, below are the changes: 1. Remove the verbose description 2. Change bar colors of same type when a mouse hover. (opaqueness: 1 -> 0.5) 3. Change the default item size from 1 to 5. (Based on the [original discussion on Slack](https://yunikornworkspace.slack.com/archives/CL9CRJ1KM/p1701742319324709?thread_ts=1701680922.070739&cid=CL9CRJ1KM), I can change it if required.) > Less is more. We have only a maximum of 10 resources (typical will be less) and 10 buckets (0-10%, 10-20%, etc). The color coding will make this visually easy to distinguish without adding extra logic. If you're concerned with being able to distinguish between the bars, add a mouse hover on each bar that changes the color to something slightly brighter for all bars of the same type. I still kept the checkbox for below reasons: 1. In some use cases, users might only care about 2~3 resources (ex: CPU/Memory/Pod). Even though we have the hover feature, it could only highlight a single resource. 2. I set a default display item size to 5, more resource will be just cluttering. But I think it's no harm to keep the flexibility to select/deselect more resoueces. @chia7712, @craigcondit, I can remove the checkbox if I got -1 for the above considerations. Otherwise I think we can keep it. Thanks for your feedback!  -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
