pbacsko commented on code in PR #796:
URL: https://github.com/apache/yunikorn-k8shim/pull/796#discussion_r1512314013
##########
pkg/cache/application.go:
##########
@@ -363,6 +363,7 @@ func (app *Application) Schedule() bool {
app.scheduleTasks(func(t *Task) bool {
return t.placeholder
})
+ app.removeCompletedTasks()
Review Comment:
We need to remove it from here to let the state transitions run for the
Task. If we removing it prematurely, it cannot reach Completed state. Another
solution is to call `Application.removeTask()` from the task itself but this
seems cleaner.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
