pbacsko commented on code in PR #825:
URL: https://github.com/apache/yunikorn-core/pull/825#discussion_r1536898153
##########
pkg/scheduler/objects/queue.go:
##########
@@ -1858,7 +1858,10 @@ func (sq *Queue) findPreemptionFenceRoot(priorityMap
map[string]int64, currentPr
}
priorityMap[sq.QueuePath] = currentPriority
- if sq.parent == nil || sq.GetPreemptionPolicy() ==
policies.FencePreemptionPolicy {
+ // Is FencePreemptionPolicy set on the queue?
+ // Does Queue's Usage already reached Max Res? If Yes, No use in
picking up the victims outside this queue path, have to find the victim queue
path with in this queue hierarchy.
+ // At last, root queue would be the fence if none met above
Review Comment:
This comment is a bit too verbose. i'd rephrase this eg. "Return this queue
as fence root if: 1. it is marked as such 2. root queue 3. allocations in the
queue reached maximum resources".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
