pbacsko commented on code in PR #833:
URL: https://github.com/apache/yunikorn-core/pull/833#discussion_r1552217585
##########
pkg/events/event_system.go:
##########
@@ -233,22 +235,36 @@ func (ec *EventSystemImpl) AddEvent(event
*si.EventRecord) {
}
}
-func (ec *EventSystemImpl) readIsTrackingEnabled() bool {
+func isTrackingEnabled() bool {
return common.GetConfigurationBool(configs.GetConfigMap(),
configs.CMEventTrackingEnabled, configs.DefaultEventTrackingEnabled)
}
-func (ec *EventSystemImpl) readRequestCapacity() int {
- return common.GetConfigurationInt(configs.GetConfigMap(),
configs.CMEventRequestCapacity, configs.DefaultEventRequestCapacity)
+func getRequestCapacity() uint64 {
+ capacity := common.GetConfigurationUint(configs.GetConfigMap(),
configs.CMEventRequestCapacity, configs.DefaultEventRequestCapacity)
+ if capacity == 0 {
+ log.Log(log.Events).Warn("Request capacity is set to 0, using
default",
Review Comment:
it's uint64, cannot be lower than 0
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscr...@yunikorn.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
