craigcondit commented on code in PR #836:
URL: https://github.com/apache/yunikorn-core/pull/836#discussion_r1559858660
##########
pkg/scheduler/objects/queue.go:
##########
@@ -131,15 +131,17 @@ func NewConfiguredQueue(conf configs.QueueConfig, parent
*Queue) (*Queue, error)
// add to the parent, we might have an overall lock already
// still need to make sure we lock the parent so we do not interfere
with scheduling
if parent != nil {
+ sq.mergeProperties(parent.getProperties(), conf.Properties)
+ sq.UpdateQueueProperties()
sq.QueuePath = parent.QueuePath + configs.DOT + sq.Name
err := parent.addChildQueue(sq)
if err != nil {
return nil, fmt.Errorf("configured queue creation
failed: %w", err)
}
// pull the properties from the parent that should be set on
the child
- sq.mergeProperties(parent.getProperties(), conf.Properties)
Review Comment:
Nit: I think this comment should go just before mergeProperties() above.
##########
pkg/scheduler/objects/queue.go:
##########
@@ -131,15 +131,17 @@ func NewConfiguredQueue(conf configs.QueueConfig, parent
*Queue) (*Queue, error)
// add to the parent, we might have an overall lock already
// still need to make sure we lock the parent so we do not interfere
with scheduling
if parent != nil {
+ sq.mergeProperties(parent.getProperties(), conf.Properties)
+ sq.UpdateQueueProperties()
sq.QueuePath = parent.QueuePath + configs.DOT + sq.Name
err := parent.addChildQueue(sq)
if err != nil {
return nil, fmt.Errorf("configured queue creation
failed: %w", err)
}
// pull the properties from the parent that should be set on
the child
- sq.mergeProperties(parent.getProperties(), conf.Properties)
Review Comment:
Nit: I think this comment should go just before mergeProperties() above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
