pbacsko commented on PR #841: URL: https://github.com/apache/yunikorn-core/pull/841#issuecomment-2051865596
> The pros is that we can pass a *Queue to queueEvents again, which eliminates the need for repeated parameters. Actually I don't want to do that, I'll explain why. The advantage of this solution is that `queueEvents` (and other `XXXX_events.go` with some changes) can be moved to a separate package in "objects", eg "objects/events". We already have a lot of files inside "objects". That way, we can clean it up a bit. This idea had already been discussed with Wilfred last year, but we were in a hurry with the whole event system so eventually it didn't happen. But in the long run, I feel it's a good thing to do. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
