chia7712 commented on PR #818: URL: https://github.com/apache/yunikorn-k8shim/pull/818#issuecomment-2053524304
> The makefile should already have the e2e-tests target depend on the tools. If it doesn't that's the proper fix. The script skips the `make tools` if the tools folder is existent. That is a bit weird that we don't check all tools in the folder. Maybe the script should call `make tools` anyway, and let `make tools` do the check and install. https://github.com/apache/yunikorn-k8shim/blob/bda57dda1a461517491d849bf8e3196ead3416a1/scripts/run-e2e-tests.sh#L74 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
